search

thom4parisot / grunt-crx

Grunt task used to package private Chrome Extensions.
https://npmjs.com/grunt-crx
MIT License
118 stars 21 forks source link

Fix options not being passed to taskConfig #47

Closed joscha closed 9 years ago

joscha commented 9 years ago

When using the task with a non-standard key location, the options never were passed to the task config, as the options were removed due to multiTask files normalization, resulting in an error

Fatal error: Unable to locate your private key.

if one changed the options.privateKey property. This was never found out, because the tests itself use the internal method extensionHelper.createObject and passed the options in. The code in tasks/crx.js was never part of the tests.

This PR fixes this, by properly passing on the options hash to the taskConfig if defined. As a side-effect it also adds coverage for tasks/crx.js.

jpalomar commented 9 years ago

:+1:

thom4parisot commented 9 years ago

Great work thanks @joscha :-)

thom4parisot commented 9 years ago

And now published as of v1.0.2 :+1:

joscha commented 9 years ago

Careful: this version is not published on npmjs, yet.

thom4parisot commented 9 years ago

@joscha it is, either through npm install grunt-crx@1.0.2 or npm install grunt-crx@beta (cf. npm info grunt-crx) – you have publish rights btw ;-)

joscha commented 9 years ago

@oncletom ah, nice, I didn't know I had publish rights, thank you :)