search

thom4parisot / grunt-crx

Grunt task used to package private Chrome Extensions.
https://npmjs.com/grunt-crx
MIT License
118 stars 21 forks source link

privateKey option ignored #50

Closed tchap closed 9 years ago

tchap commented 9 years ago

When I set privateKey in the options object, it is somehow ignored. Things start working when I move it to the top level config. So, example:

DOES NOT work:

crx: {
  prod: {
    options:
      privateKey: "..."
  }
}

DOES work:

crx: {
  prod: {
    privateKey: "..."
  }
}
thom4parisot commented 9 years ago

Yep, the online doc is about v1.x.x whereas the default installed package is v0.3.x (cf. #45).

tchap commented 9 years ago

Right... Shouldn't master represent what is on NPM?

thom4parisot commented 9 years ago

Indeed but not because of #44, eventually fixed by oncletom/crx#41

tchap commented 9 years ago

Ok, will close this one...

thom4parisot commented 9 years ago

:smiley: