search

thom4parisot / tld.js

JavaScript API to work easily with complex domain names, subdomains and well-known TLDs.
https://npmjs.com/tldjs
MIT License
460 stars 55 forks source link

returns null for http://vikram_tiwari.com #127

Open VikramTiwari opened 6 years ago

VikramTiwari commented 6 years ago

similar to https://github.com/oncletom/tld.js/issues/117

remusao commented 6 years ago

Hi @VikramTiwari,

Thank you for your feedback!

In this case, this is because currently the _ is not considered valid when found inside a domain. Related work: #122

Hopefully we will soon have a better behavior and a way to customize it.

luckyb56 commented 6 years ago

@remusao You are not merging #122 into master for now?

remusao commented 6 years ago

@luckyb56, I'm all for it, but I would like to get some feedback from @oncletom on this one. I also opened another PR #128 to propose a possible new set of defaults (which would also solve the issue of hostname validation, as well as a few other things). How do you think we shall proceed on this?

luckyb56 commented 6 years ago

PR #128 Looks great.