Clicking Link to last-fm account does nothing

thom4parisot / webextension-fip

Minimalistic WebExtension to listen to FIP Radio, the best eclectic radio station (for Firefox, Chrome, Opera and Edge)

https://chrome.google.com/webstore/detail/fnhlecpfnocgmmmghkjcipmhdpmpddii

MIT License

34 stars 10 forks source link

Clicking Link to last-fm account does nothing #78

Closed edouard-lopez closed 5 years ago

edouard-lopez commented 6 years ago

Love the extension ❤️

Firefox

58.0b16 (64-bit)

Excpeted

Clicking the link open a page to last.fm to connect the extension or something like that.

Actual

Nothing happen.

Link value is

unsafe:moz-extension://f8d44b9e-6d07-493b-a88d-39ee1ea1ef42/options/index.html#

thom4parisot commented 6 years ago

Thanks!

I think this tweet refered to the same issue: https://twitter.com/floriankarmen/status/953970919533371394

When I use about:debugging to debug the extension, I can see the redirect_uri is missing. It might be lost in translation between the Chrome Extension API and the WebExtensions API—from the top of my head, Chrome provides a safe OAuth2 callback URL to perform actions such as Last.fm pairing.

thom4parisot commented 5 years ago

It should work on the latest version (v1.2.4) 👍