search

thomas-coldwell / expo-image-editor

A super simple image cropping and rotation tool for Expo that runs on iOS, Android and Web!
164 stars 34 forks source link

Make it stable #62

Open innonguyen opened 3 years ago

innonguyen commented 3 years ago

Dear Thomas,

I think you should includes and fix something to make it stable version. Here're what I found:

  1. These following dependencies should not be devDependencies because your library won't work without it. You should keep it in list of dependencies.
  1. ImagePicker.requestCameraRollPermissionsAsync() is deprecated in favour of ImagePicker.requestMediaLibraryPermissionsAsync()

You can replace it in your home instruction in readme file.

Hope it helps

Joshmatjjen commented 2 years ago

True @innonguyen . this need to be adjusted I had to install those Libary one after the other

ajenkins commented 2 years ago

I agree that recoil should definitely be in the dependencies. However, expo-gl and expo-image-manipulator are already listed in peerDependencies. That does mean that you need to install those yourself, but that's kind of what peerDependencies is for. The Readme should probably call out that you need to install those yourself though. I submitted a PR to add recoil and react-native-gesture-handler to dependencies.