thomas-daniels / Chess.NET

[No longer maintained] A .NET chess library, written in C#
MIT License
50 stars 19 forks source link

Invalid test data on TestGetValidMovesBlackBishop #13

Closed ghost closed 5 years ago

ghost commented 6 years ago

The expected test values for this test duplicate values along the same axis, and do not have the appropriate values on the second direction of the bishop's moves.

https://github.com/ProgramFOX/Chess.NET/blob/aa22494d7736c7262a9667ee381311e8c360016b/ChessDotNet.Tests/ChessGameTests.cs#L2801

Should be more like this:

List<Move> expected = new List<Move>()
            {
                new Move("D4", "A1", Player.Black),
                new Move("D4", "B2", Player.Black),
                new Move("D4", "C3", Player.Black),
                new Move("D4", "E5", Player.Black),
                new Move("D4", "F6", Player.Black),
                new Move("D4", "G7", Player.Black),
                new Move("D4", "H8", Player.Black),
                new Move("D4", "C5", Player.Black),
                new Move("D4", "B6", Player.Black), 
                new Move("D4", "A7", Player.Black), 
                new Move("D4", "E3", Player.Black), 
                new Move("D4", "F2", Player.Black), 
                new Move("D4", "G1", Player.Black)
            };

I have a bunch of changes on my fork, so I'm not feeling like submitting a pr to fix this, but just figured I'd let you know. 😸