search

thomas-daniels / Chess.NET

[No longer maintained] A .NET chess library, written in C#
MIT License
50 stars 19 forks source link

Board json serialization/deserialization... #14

Closed nvrnight closed 6 years ago

nvrnight commented 6 years ago

It would be nice to be able to easily serialize/deserialize the game board, currently chokes up on the King piece because of not having an eligible constructor using Newtonsoft.Json.

ghost commented 6 years ago

@nvrnight How interested would you be in writing that functionality? I'm not interested in writing this fix (not relevant to my interests) but I can help you with that if you'd like. (Code review and pair programming are the best things I can offer.) I'm not the maintainer but I've been spending a lot of time in this code for another project.

nvrnight commented 6 years ago

If there's someone around to review/merge a pull request I could probably put in the time to do it.

nvrnight commented 6 years ago

I'm unfortunately struggling to get .NET Core 1.x stuff building, I'm on 2.0. I've downloaded the 1.x SDK and am trying to see if I can switch my version to it some how. I think once I get the thing to compile everything else will be a cakewalk. I've already got an idea of what needs to be changed.

nvrnight commented 6 years ago

I just migrated the code to use .NET Core SDK 2.0 rather than fiddling with it. I don't think there should be any compatibility issues with the changes needed to be made, incoming pull request shortly.