Mismatch of quality definitions

thomas-ernest / plugin.video.arteplussept

Watch Arte+7 content in Kodi

GNU General Public License v2.0

6 stars 4 forks source link

Mismatch of quality definitions #39

Closed maaaaz closed 6 months ago

maaaaz commented 7 months ago

Hello there,

This file contains quality parameters: https://github.com/thomas-ernest/plugin.video.arteplussept/blob/8d1ade5e63e6325f72c6653fa59f4ced497fc856/resources/settings.xml#L15

But it seems there is a mismatch of values: having "SQ" with "High Quality", "High" with "Low Quality" is not consistent:

High Quality (HQ) should be HQ
and Soft Quality (SQ) should be Low.

Not the opposite.

Cheers.

thomas-ernest commented 7 months ago

Hello @maaaaz ,

I agree that quality mapping/naming is misleading. I double checked Arte HBB TV API and I confirm that SQ is for High Quality 720p , EQ is for Medium Quality 406p and HQ is for Low Quality 360p. You can look at the log attached : 20231226_184633564184_hbbtv_streams.json

I will open a PR to rename configuration to avoid this misleading situation. Please review and approve. If you can test it upfront, it would be great.

Thank you, Best regards,

thomas-ernest commented 6 months ago

to be released soon.

thomas-ernest commented 6 months ago

Released in version 1.4.2, available in official kodi repo : https://github.com/xbmc/repo-plugins/pull/4443