search

thomas-krenn / TKperf

Performance test tool for SSDs, HDDs and RAID devices
https://www.thomas-krenn.com/en/wiki/TKperf
GNU General Public License v3.0
48 stars 23 forks source link

Convert to Python 3 #37

Closed onitake closed 3 years ago

onitake commented 4 years ago

Conversion mostly done with the help of 2to3. Not fully tested yet.

Fixes: #36

gschoenberger commented 3 years ago

I think universal_newlines would be a great choice, as we might support Python versions < 3.7!

onitake commented 3 years ago

All right, I added the universal_newlines flag and removed the str.decode calls.

Velociraptor85 commented 3 years ago

So my testruns worked - as far as I can tell https://github.com/onitake/TKperf/pull/1

onitake commented 3 years ago

Ok, I merged your changes. Looks like there were a few more Popen calls. :sweat_smile:

gschoenberger commented 3 years ago

I made a full TKperf run with a SSD performance test on an USB stick and had no problems with the current Python3 code. I guess I will make a new release after I have finished my tests.

Thanks for the great support!

tniedermeier commented 3 years ago

Thanks for the great support @onitake also from my side! I also started a TKperf test (new Python3 code) with an Intel SSD, seems fine so far. But due to the large size of the SSD, the test isn't finished yet.