thomas-krenn / check_ipmi_sensor_v3

Monitoring plugin to check IPMI sensors
https://www.thomas-krenn.com/en/wiki/IPMI_Sensor_Monitoring_Plugin
GNU General Public License v3.0
54 stars 21 forks source link

Optional additional FRU information in output #41

Closed MarcusCaepio closed 4 years ago

MarcusCaepio commented 4 years ago

Good morning y'all, Beside the serial number, we are also interested in the Asset Tag and Board Information in the output. I am currently working on "--assettag" and "--board" options to display them. My idea is, that "--fru" is mandatory for both new options. This way, the script just uses the already existent "@fruoutput" and the code just has to be expanded a little bit.

I would create a PR, when it's finished. Cheers and have a nice weekend, Marcus

gschoenberger commented 4 years ago

Yes! Please create a PR and I will review/merge it,

THX - Georg

MarcusCaepio commented 4 years ago

Hi Georg, PR is done. If you merge it, I will fork the Icinga2 Repo, adjust the ITL command and create a PR for it to have the current version also running with the next release (if they merge it :D ).

Cheers, Marcus