search

thomas-lowry / figma-plugin-ds

A small lightweight design system for use in Figma Plugins
MIT License
693 stars 71 forks source link

I suggest replacing it #19

Open Andreslav opened 4 years ago

Andreslav commented 4 years ago

https://github.com/thomas-lowry/figma-plugin-ds/blob/f58d127fae0f0e566ca834b3e48bbbb5e1939dc9/js/selectMenu.js#L376

I suggest replacing it with because:

  1. The menu is hidden above, but you should at least display it again.
  2. replaceWith does not create new nodes, which preserves their properties.
menu.style.display = "";
parent.replaceWith(menu)