search

thomas-lowry / figma-plugin-ds

A small lightweight design system for use in Figma Plugins
MIT License
693 stars 71 forks source link

Backward compatibility is broken? #29

Closed alexandrtovmach closed 4 years ago

alexandrtovmach commented 4 years ago

I just checked classnames for components, and it seems not backward compatible with previous realization. For sure it looks better, because it's kind of BEM, but good to mention this in README

thomas-lowry commented 4 years ago

I mentioned it in the PR. Calls I had to make to simplify markup to maintain closer relationship to the Svelte version for maintainability. Checkboxes and switches I believe were the main ones and phased out use of the mixins for type to reduce any dependency on sass to use it.

Will do my best to avoid breaking changes in the future but can’t guarantee.

On May 18, 2020, at 4:18 AM, Alexandr Tovmach notifications@github.com wrote:

 I just checked classnames for components, and it seems not backward compatible with previous realization. For sure it looks better, because it's kind of BEM, but good to mention this in README

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.