search

thomas-lowry / figma-plugin-ds

A small lightweight design system for use in Figma Plugins
MIT License
693 stars 71 forks source link

Spinning icon is not centered correctly #38

Closed didoo closed 3 years ago

didoo commented 4 years ago

When an icon (in particular the spinner) is spinning, the center of the icon has an offset that makes the animation look wrong: Screen Recording 2020-09-09 at 11 25 19

You can see a live demo here: https://codesandbox.io/s/vigilant-dubinsky-ywl8q?file=/index.html

It is caused by this line: https://github.com/thomas-lowry/figma-plugin-ds/blob/e1acbac7a56937b784b34366bcd7ca7386280253/src/styles/components/_icon.scss#L11 which I have no idea why it was introduced. Looks a strange declaration to me, probably should just be:

background-position: 50% 50%;

Do you think we can fix this? Happy to open a PR for this.

taitems commented 3 years ago

Just hit this one myself, if you don't feel like making a PR I will?

didoo commented 3 years ago

@taitems you can try but I can't see much activity on the repo, so I suspect it will not be picked up (that's why I didn't). if you want to try, more than happy (in that case I'll submit other PRs for other issues).

thomas-lowry commented 3 years ago

I just updated this! thank you for flagging.