search

thomas-mauran / chess-tui

A chess TUI implementation in rust 🦀
https://crates.io/crates/chess-tui
MIT License
361 stars 20 forks source link

fix: history entry must have a `PieceType`, and therefore does not need to be an `Option<PieceType>`, but rather a `PieceType` #64

Closed JeromeSchmied closed 4 months ago

JeromeSchmied commented 6 months ago

This PR adds refactor the History to create a new type pub type HistRec = (PieceType, String);

thomas-mauran commented 6 months ago

LGTM, you can rebase from main to resolve the conflicts in your IDE and then push again

thomas-mauran commented 5 months ago

ping @JeromeSchmied just need to fix the conflict for a merge when you have time

JeromeSchmied commented 5 months ago

ping @JeromeSchmied just need to fix the conflict for a merge when you have time

yup, I know, but I find this rebasing quite tricky, so it'll take some more time

thomas-mauran commented 5 months ago

sure thing no problem @JeromeSchmied @ me when you are done mate !

thomas-mauran commented 5 months ago

Hello @JeromeSchmied checkout pr #65 @nicholasmello did another refactor of the move history and added a proper struct for it