Restore compatibility with PHP 7.4 by fixing regular expressions - Githubissues

thomas-rcv / admidio-written_communications

This Plugin for Admidio (Management for Members of organizations, clubs and divisions) creates form letters to defined members of an Admidio role or to individual recipients.

2 stars 3 forks source link

Restore compatibility with PHP 7.4 by fixing regular expressions #20

Closed alexanderharm closed 3 years ago

alexanderharm commented 3 years ago

I upgraded simplehtmldom to the latest stable version since it contained illegal regular expressions (- in character class not escaped). I also added some minor fixes to the regular expressions used in plugin-code. I will try and bump PHPWord as well in the coming days since it parses HTML natively and is quite outdated.

alexanderharm commented 3 years ago

I thought so initially but then the original plugin shipped them as well. Removed and only kept license, class and changelog.

alexanderharm commented 3 years ago

Yes, in v4-beta3 and the latest 3.x

alexanderharm commented 3 years ago

Do you publish both versions (for 3.x and 4.x) from master? Couldn't find corresponding tags or branches...

Fasse commented 3 years ago

No, in this repository there are no tags or branches. Therefore it's not possible to publish version 3.x from this.

Could you send me the 3.x plugin. I will then publish it on our homepage.

alexanderharm commented 3 years ago

written_communications_3.3.2.zip written_communications_3.2.2.zip

v3.x -> 3.2.2
v4.x -> 3.3.2

Fasse commented 3 years ago

Thank you very much for your work. I have updated the plugin page.