search

thomasasfk / sd-webui-aspect-ratio-helper

Simple extension to easily maintain aspect ratio while changing dimensions. Install via the extensions tab on the AUTOMATIC1111 webui.
https://github.com/thomasasfk/sd-webui-aspect-ratio-helper.git
408 stars 66 forks source link

FEATURE REQUEST: Automatically change hires fix resoultions too #24

Open tusharbhutt opened 1 year ago

tusharbhutt commented 1 year ago

Thanks for the the neat extension! Is it possible that when you flip aspect ration for the HxW that it could also change the HxW of the Hires,fix too?

thomasasfk commented 1 year ago

Ah. This is an oversight, well spotted! I'll give it a try when I have time. Thanks for raising.

thomasasfk commented 1 year ago

Hey @tusharbhutt - this seems to already work when I try it, can you clarify what you mean?

tusharbhutt commented 1 year ago

Hey @tusharbhutt - this seems to already work when I try it, can you clarify what you mean?

Sure! When the "Upscale by" in Hires is picked, the resolutions do change:

image

But when the output resolution is set with "resize X to", it does not change:

image

I thought that perhaps if the hires output was set to 1024x1536 and the ratio changed to 16:9, then the hires output would be set to 1536x864. The input resolution does change under height and width, but not under the ones for Hires.fix

thomasasfk commented 1 year ago

Ah! thank you very much, that makes it more clear. I'll see when I have time to fix this!

thomasasfk commented 1 year ago

Planning on taking a look a this tomorrow as I have some time, will see how difficult it is! Sorry for the delays.

thomasasfk commented 1 year ago

This is definitely possible, however a bit of a speedbump is that it's considered disabled when it's 0 - I think I'll need to parameterise the minimum values to allow for it to be 0 as opposed to 64 which is used by the other ones. Not sure when I'll have time to sit down and fully implement it though.