thomasasfk / sd-webui-aspect-ratio-helper

Simple extension to easily maintain aspect ratio while changing dimensions. Install via the extensions tab on the AUTOMATIC1111 webui.
https://github.com/thomasasfk/sd-webui-aspect-ratio-helper.git
406 stars 66 forks source link

a1111 webui's slider 8 incremental step wont work if [JavaScript aspect ratio controls] is activated #34

Closed bryanray closed 1 year ago

bryanray commented 1 year ago

commit: [a9fed7c3]

a1111 webui's slider 8 incremental step wont work if [JavaScript aspect ratio controls] is activated,

this perhaps is always the case :)

bryanray commented 1 year ago

javascript icons/ lengends are not centered as it should be usually, instead they are left aligned.

this particular issue appear in latest update :))

thomasasfk commented 1 year ago

Hey! The step was deliberately set to 1 so the aspect ratio could be as precise as possible.

It's very easy to make configurable though, so I'll add an option for it when I have time.

https://github.com/thomasasfk/sd-webui-aspect-ratio-helper/blob/50cf127c44fc100e3e78b84f288cb07f6c7dc67e/javascript/aspectRatioController.js#L79

In terms of the styling, it should be easy enough to center the text, I'll do that at the same time as the other change!

Thanks for raising.

bryanray commented 1 year ago

i wish i know how to code, then i can contribute to this plugin :) LOL

bryanray commented 1 year ago

Hey! The step was deliberately set to 1 so the aspect ratio could be as precise as possible.

It's very easy to make configurable though, so I'll add an option for it when I have time.

https://github.com/thomasasfk/sd-webui-aspect-ratio-helper/blob/50cf127c44fc100e3e78b84f288cb07f6c7dc67e/javascript/aspectRatioController.js#L79

In terms of the styling, it should be easy enough to center the text, I'll do that at the same time as the other change!

Thanks for raising.

another really important thing is, the "off" options should have been off to make 8 incremental stepping on again, that would be great!

thomasasfk commented 1 year ago

https://github.com/thomasasfk/sd-webui-aspect-ratio-helper/issues/36#issuecomment-1492479473

bryanray commented 1 year ago

thanks dude :)

amazing app you've done here