thomasballinger / observable-jupyter

Embed visualizations and code from Observable notebooks in Jupyter
https://observable-jupyter.readthedocs.io/
ISC License
56 stars 10 forks source link

runtime update causes implicit dependencies not to run their side effects #5

Closed thomasballinger closed 3 years ago

thomasballinger commented 3 years ago

A good API change (any falsy value observer value causes a cell not to be observed) causes a behavior change in observable_jupyter: when specific cells are embedded, other cells they implicitly depend on for side effects will not run!

This change was published in 0.1.8 for about five minutes, from 5:43pm to 5:49 today, at which point I deleted the release.

This may be a behavior uses want — the hide= option that robservable uses is nice — but this would be a confusing breaking change to surprise users with. observable_jupyter users expect all cells to be run by default.

thomasballinger commented 3 years ago

Fixed in https://github.com/thomasballinger/observable-jupyter/commit/2030959d9eff5744af5a123cf2206ef5e6cac099