search

thomasborgen / storage-bucket

For easy GCP Storage Bucket interaction
MIT License
6 stars 0 forks source link

upgrade to returns 14 #37

Closed thomasborgen closed 4 years ago

thomasborgen commented 4 years ago

closes: #34

semver will be major since this is breaking.

codecov-commenter commented 4 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          197       183   -14     
  Branches         9        10    +1     
=========================================
- Hits           197       183   -14
Impacted Files Coverage Δ
storage_bucket/client.py 100.00% <100.00%> (ø)
storage_bucket/create.py 100.00% <100.00%> (ø)
storage_bucket/delete.py 100.00% <100.00%> (ø)
storage_bucket/delete_file.py 100.00% <100.00%> (ø)
storage_bucket/download_file.py 100.00% <100.00%> (ø)
storage_bucket/get.py 100.00% <100.00%> (ø)
storage_bucket/list.py 100.00% <100.00%> (ø)
storage_bucket/list_files.py 100.00% <100.00%> (ø)
storage_bucket/upload_file.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de8fc03...4a0e7d5. Read the comment docs.

thomasborgen commented 4 years ago

I think we should start a changelog.md now and add it before we merge. And this merge will mark version 1.0.0, but only because it breaks backwards compatibility and not that its a "milestone"