Spinner shown only once

thomasboyt / react-spin

React component wrapper for spin.js

27 stars 23 forks source link

Closed Coffei closed 9 years ago

Coffei commented 9 years ago

When stopped prop changes from true to false, the spinner is not shown.

Coffei commented 9 years ago

The cause seems to be calling spin on line 21 without the target DOM node. I have created a pull request #2 for this. Please review and merge.

samsel commented 9 years ago

@thomasboyt can this change be published to npm? thanks!

thomasboyt commented 9 years ago

Sorry, just now seeing this - will try to get it merged tonight :)

Coffei commented 9 years ago

Hi, any update on this? It is really just a very small fix and it should not take more than a few minutes to merge and test it.

thomasboyt commented 9 years ago

merged https://github.com/thomasboyt/react-spin/pull/2, thanks and sorry for such a long delay!