search

thomaschampagne / elevate

A sport app to "Elevate" your training experience and goals! Track your fitness and progressions over time. Analyse deeper your activities. And more...
https://thomaschampagne.github.io/elevate-docs/
Mozilla Public License 2.0
1.28k stars 175 forks source link

Swim Stress Score being recorded for rest intervals #1116

Open mcgmar opened 2 years ago

mcgmar commented 2 years ago

Describe the bug Very high Max Pace is being applied to rest intervals where no swimming took place, which is resulting in very high Swim Stress Score for the activity.

To Reproduce Steps to reproduce the behavior:

  1. Go to my swim activity dated 28/06/2022 named "Afternoon Swim" - see attached
  2. Click on 'Intervals'
  3. Scroll over to 'Max Pace'
  4. See error where very fast pace is recorded even though there is no distance recorded.

Expected behavior A blank or zero for Max Pace when the interval distance is blank or zero

Screenshots Attached.

Environment

Thank you for your time Mark image

Jeecie commented 2 years ago

Seems to be caused by the distance being null for rest intervals, rather than 0 if i compare with older swims. Also, the moving time = elapsed time on incorrect swims image

Jeecie commented 2 years ago

Does not happen when i upload the same activity manually from the .fit file This is the same activity as above image