Open thomaschampagne opened 9 years ago
@thomaschampagne Assign this to me. I want to investigate on how to achieve this after closing #10.
@praveentiru Haha you're on top ! :)
Github don't dont allow me to assign you on this :/ wtf.
I looked about the extension migration process to FF. It's pretty hard !!!
As a workaround to give stravistix "for all" i thinked about cross OS standalors stravistix with "Node Web kit @ https://github.com/nwjs/nw.js/". Associated ticket is https://github.com/thomaschampagne/stravistix/issues/175. For example the well know popcorn time project and theirs forks are based on node webkit.
@thomaschampagne I don't know if you have looked at new development from Firefox. Firefox is planning to release WebExtensions whose architecture seems very similar to Chrome's extensions architecture.
The first stable release is expected in Firefox 48 (which should come out in August). With little changes we might able to provide this as add-on for Firefox
@praveentiru Woow sounds goods, Things can change then !! I rode firstfruits of that from an old bill (https://hacks.mozilla.org/2015/10/porting-chrome-extensions-to-firefox-with-webextensions/) but moreexperimental...
I will deep at a closer look into your given infos ! Thanks
Areas that have to be addressed:
Comment to be edited as new areas are discovered
It seems there's some support of sync storage implemented since Firefox 53 (April 19, 2017), see release note.
The firefox 57 is released, and supports WebExtentions.
@rmv125 Did you try a build of stravistix on it?
I just tried with Chrome Store Foxified. I can convert the app & install it, but it fails when I try to sync:
@thomaschampagne I didn't tried converting it yet, but mozilla extension test says that it's possible. https://www.extensiontest.com/test/f85452f0-dc36-11e7-9408-1de26b462a9c
Also, here is the list of incompatibilities: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Chrome_incompatibilities Would be nice if you look on it.
Tried to install:
One manifest error less now. But it's not synching. Are we far from having it working in Firefox?
We are not far. I have this in sight. Some other technical stuff must be done before like switch from systemjs to webpack for the core plugin. It will be easier to migrate to FF.
I dropped one today: removed old app. So this has not to be migrated to work with FF
@thomaschampagne What is the status on this? I've forked your repo to work on this issue if it's still useful/needed
@thomaschampagne I'm going to try and start working on this this week, can tou assign it to me? I'll report my progress
@MQuaresma damn i can't assign you! wtf :/
It might be because I'm not yet a contributor, I'm not sure
@MQuaresma Should be ok once you accepted the invite ;)
@thomaschampagne Thanks, just did ;) Getting to work today hopefully
@MQuaresma Perfect !! I let you create a branch from develop
named like feature/15-firefox-support
or the name you want :)
Thanks in advance for you help !! Support of firefox could be awesome for lot of people!
@MQuaresma Did you start something on? :)
@thomaschampagne Yeah, sorry for the slow progress, I've been a little bit busy lately with an internship I'm enrolled in. I've been reading up on the WebExtensions API and the Chrome Incompatibilities article on MDN documentation.
Dont worry man. Just getting some news. No stress on, you have no duty for this. Good luck for the internship ;)
Le dim. 19 août 2018 à 11:55, Miguel Quaresma notifications@github.com a écrit :
@thomaschampagne https://github.com/thomaschampagne Yeah, sorry for the slow progress, I've been a little bit busy lately with an internship I'm enrolled in. I've been reading up on the WebExtensions API and the Chrome Incompatibilities article on MDN documentation.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thomaschampagne/stravistix/issues/15#issuecomment-414116685, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJRpavZ-A_65QcUvlfbE9jBp2NOtHo-ks5uSTYUgaJpZM4Di3D6 .
-- Thomas Champagne http://thomaschampagne.github.io
What about this fork? https://addons.mozilla.org/en-US/firefox/addon/stravistix-for-firefox/
Is this working properly? (Can't test... i'm in vacation with smartphone only)
Yes it seems to work! I'm using it right now.
But I'm a very new strativix user so I can't check everything because I don't know well every feature. I could synchronize all my activities.
It seems to work here too. Three attempts were required to synchronize >1300 activities. :+1:
Yeah I tried multiple times too
Nice, that guy have to share his work here! Stats are working for a single activity on strava.com ?
On Thu, Aug 23, 2018, 11:58 Cédric Delpoux notifications@github.com wrote:
Yeah I tried multiple times too
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thomaschampagne/stravistix/issues/15#issuecomment-415360865, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJRpWdidHmy_NrwPgqOe3G6iS9bbRGCks5uTny8gaJpZM4Di3D6 .
-- Thomas Champagne http://thomaschampagne.github.io
Tried it & looks to work fine. @thomaschampagne yes, extended stats for activities is functional too.
Yes, it's working on a Strava activity page too.
Here is the fork repo: https://github.com/CodeNKasch/stravistix
There is no more commits
I found it. This is the firefox feature branch: https://github.com/CodeNKasch/stravistix/tree/feature/firefox
@MQuaresma That upper post might help you :)
@xuopled Nice found !
I just opened an PR to open the discussion and reach the author: https://github.com/thomaschampagne/stravistix/pull/648
Hey there, i will Clean my fork and create auf Patch for you. This way it should be easyer to apply to your repository. Only thing thats not working atm is the Autoclose of the sync dialog.
It will take some time since im fully scheduled atm.
Cheers, Karl
@CodeNKasch Great !!
Take your time. This ticket has more than 3 years...
Keep us in touch
Thanks for the work performed !
@CodeNKasch let me know if you need anything and I'll try and help out
I updated to the new version but dont had the time to clean it.
@thomaschampagne @CodeNKasch What is the status on this issue? There doesn't seem to be a working version of Elevate on Firefox, shall I take this one on again?
I've been waiting for the Firefox version for a long time, is it expected to be released in the next few months?
I hope a version for Firefox in the future. Thanks.