search

thomasd / MultiUploadDialog

An MODx addon replacing the outdated default upload dialog.
12 stars 5 forks source link

replace the core? #1

Closed rthrash closed 10 years ago

rthrash commented 10 years ago

Hey this looks awesome! Would you consider contributing as a replacement for the core upload functionality?

eminos commented 10 years ago

This should definitely be in the core!

thomasd commented 10 years ago

@rthrash: I would be honored if you consider to put this in the core! But I still think about maintaining this addon for older MODx versions. I have to test, but I think providing compatibility back to 2.0.x is not hard to reach. What do you think?

rthrash commented 10 years ago

We would love to see this make it in. Have you signed a CLA? See the right column here if not (requires login): http://develop.modx.com/contribute/

Maintaining as an add-on would be great, too. Look forward to pushing this into the MODX core!

Best regards, Ryan Thrash MODX President & Co-founder // http://thrash.me // http://modx.com

thomasd commented 10 years ago

Great! Yes, I've already signed a CLA.

How would the integration in the core work? Do I have to do something? Or do you fork this and integrate whats needed? I do not have much experience in shared working on codebases. Any help and/or suggestions from your side is very much appreciated.

rthrash commented 10 years ago

We'll get this assigned to someone to work with you on it. Thanks for signing the CLA!

wuuti commented 10 years ago

+1 for core.

theboxer commented 10 years ago

Hello @thomasd the best way how to include this awesome component into the core would be sending a Pull Request (PR).

First of all you will need to fork modxcms/revolution repository, then clone it to your localhost and install MODX. (Here you can find a tutorial for installing MODX from git).

Before installation please make sure you are in a develop branch (because this is a new feature and it will be available from next minor release - currently 2.3).

After installation please create a new branch from develop (via git checkout -b newbranch origin/develop), you can name the branch whatever you want, would be great to name it as something that the PR does (for example feature-multiuploader).

Now you can modify the files to replace the current file uploader with yours.

When you finish the work, commit changes and push the branch to your GitHub. After opening GitHub pages and your revolution fork, you should be able to see a PR suggestion in the bar above the list of files. Click on compare and pull request, write a description for the PR and submit it.

If you will need any kind of help, feel free to contact me here or directly on Skype: the_boxer.

jcdm commented 10 years ago

This is exciting - thank you thomasd for writing it and rthrash for always being on the lookout for ways to improve the core!