search

thomasdelaet / python-velbus

A python library to control the Velbus home automation system
MIT License
17 stars 8 forks source link

Fixed input channels status VMBGPO module #34

Closed brefra closed 4 years ago

brefra commented 4 years ago

This PR fixes issue #32 by adding submodules (addresses) to allow status tracking of input channels 9 - 32. I had to do some code changes to the channelname assembly to get this right. It succesfully works for my setup together with other Velbus module types so the "general part" is not messing up other modules.

Note: I suspect that sort of same code change should be apply against the VMBGPOD module too. As I'm unable to test this I did not include this within this PR. If there is an interest I'll submit a separate PR

Cereal2nd commented 4 years ago

Cool PR I'll test this one out today and if it works we will merge it. We will certainly need the same thing for the good modules as these also use the submodules

Cereal2nd commented 4 years ago

i tested i locally and this one seems to solved a lot of problems :)

can we do the same thing for the vmbgpod?