search

thomasdelaet / python-velbus

A python library to control the Velbus home automation system
MIT License
17 stars 8 forks source link

Fixed moduletype message parsing for old modules #37

Closed brefra closed 4 years ago

brefra commented 4 years ago

Some older modules don't expose a serial number or memory map in the module type message. As result these properties were populated with a wrong (mostly identical) value. Because the HomeAssistant integration assign unique ID's based on the serialnumber value a second module of the same type don't get an unique ID and wil be missing from detection. This PR wil solve this.

Cereal2nd commented 4 years ago

what will happen in HASS in case no serial is there?

brefra commented 4 years ago

At the HASS side when the serial is 0 (not set) it wil take the module address as identifier. Specific code is here