search

thomasdeppisch / videojs-xr

Plugin for using WebXR with videojs, based on videojs-vr
MIT License
10 stars 3 forks source link

Changing source while XR session is started and playing #19

Open jarcky opened 2 years ago

jarcky commented 2 years ago

Hi there,

I'm using this repository and making a few improvements and adaptations for my needs. As videojs-xr saved a lot of time and work for me, I will open little PRs with my changes when all of them are fully tested and stable so they can be reviewed and merged if useful.

A part from that, I'm a bit stucked with one thing and I would appreciate some help. I'm using the playlist plugin and triggering a source change while the XRSession is started and playing, but the session is not reloading the source and I have to end the XRSession and start it again manually to cotinue with the new source.

I've tried many things, like automatically calling the "vrdisplaydeactivate" and "vrdisplayactivate" events when performing the source change, avoiding the use of the playlist plugin and many other crazy and not so crazy tests, but all without a successful or acceptable result.

I supose the best solution would be recreating the scene based on the new source so the change would not require exiting the XRSession or odd things like this, but I don't know what more I can try at the moment.

I would appreciate if somebody can help me with that. I know that maybe is a really simple question but it is my first project using WebXR (I used WebVR a little bit more, but not much) and with that kind of features/needs.

Thanks in advance!

thomasdeppisch commented 2 years ago

Hi,

I will open little PRs with my changes when all of them are fully tested and stable so they can be reviewed and merged if useful.

Sounds great! :)

I supose the best solution would be recreating the scene based on the new source so the change would not require exiting the XRSession or odd things like this, but I don't know what more I can try at the moment.

Tbh I never tried changing the source inside an active environment and am not sure if that is possible. I assume you would have to not only change the source but also "reset" certain parameters of the player (don't know which ones). The current version of videojs-xr does not have such functionality so you probably would need to add a function that does that.