search

thomasfr / hass-addons

MIT License
14 stars 24 forks source link

Generalize s3-backup #5

Closed hobbypunk90 closed 1 month ago

hobbypunk90 commented 1 year ago

Closes #2 :grin: I run my changes with scaleways object storage :relaxed:

thomasfr commented 1 year ago

Thanks for the pull request. Very much appreciated!! I will take a look into it this weekend

hobbypunk90 commented 1 year ago

@thomasfr i hope it's okay, that i've added also an option to set the max_concurrent_requests param for aws.

hobbypunk90 commented 1 year ago

@thomasfr do you had time for a look? :)

garritfra commented 1 year ago

Really looking forward to seeing this merged. Thanks for your work! :)

hobbypunk90 commented 1 year ago

sorry for my long delay, i was a little bit busy the last weeks 😒 i hope everything is fine again after your accident.

hobbypunk90 commented 1 year ago

@thomasfr i reverted the renaming stuff. I fully understand why you don't like the way i set the configs, i have a similar problem with that. The problem is, that the endpoint/endpointapi is not able to setup via cli, as i know :see_no_evil:

This is the reason why i think, it's better to use the aws configure way to setup, instead of mix env variables, aws configure and cli :joy:

bwint commented 1 year ago

Hi there! Are there any news regarding this pull request? Would absolutely love to use this repo for backing up my hass instance to a non aws s3 storage.

DavidBoettger commented 11 months ago

Hi, Are there any updates? It seems to me that everything should be working fine. I am really looking forward for this.

jpillora commented 9 months ago

Keen to use cloudflare R2 with this PR 😄