search

thomasfredericks / Bounce2

Debouncing library for Arduino and Wiring
MIT License
580 stars 172 forks source link

Hardware abstraction should be by composition rather than inheritance #70

Open jamesmyatt opened 4 years ago

jamesmyatt commented 4 years ago

Especially since there is a Button class now, the hardware abstraction should be done by composition rather than inheritance. For example, it's not possible to define a Button instance that uses something other than digitalRead to read the state. What do you think?

https://en.wikipedia.org/wiki/Composition_over_inheritance

thomasfredericks commented 4 years ago

Hum, interesting. But how would this be implemented?

KenwoodFox commented 2 years ago

I also want to find a way to do this, id like to be able to define a button instance with an input that is not digitalRead, maybe add in an override?

thomasfredericks commented 2 years ago

@KenwoodFox this can already be implemented. See the source for class Bounce in Bounce2.h.

You can set your custom override for digitalRead : virtual bool readCurrentState() { return digitalRead(pin); }

KenwoodFox commented 2 years ago

@KenwoodFox this can already be implemented. See the source for class Bounce in Bounce2.h.

You can set your custom override for digitalRead : virtual bool readCurrentState() { return digitalRead(pin); }

This is pretty awesome! thanks so much.

KenwoodFox commented 2 years ago

@KenwoodFox this can already be implemented. See the source for class Bounce in Bounce2.h.

You can set your custom override for digitalRead : virtual bool readCurrentState() { return digitalRead(pin); }

Sorry to ask, but where would you implement this? Should this be done for every button instance you create or do i need to make my own button class using inheriting from bounce?

Thynix commented 2 years ago

It isn't a complete replacement because it doesn't have complex debouncing techniques, but the Debouncer library allows passing in the value to use.