Closed xaviergriffon closed 1 year ago
Base: 85.64% // Head: 98.32% // Increases project coverage by +12.68%
:tada:
Coverage data is based on head (
7dfbacf
) compared to base (5c47b55
). Patch coverage: 95.02% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This looks very promising. I called some URLs wth the get_response.py script and the responses look reasonable. I didn't test HA integration (and I don't quite know how to do this: using a different repository and branch with HA).
This looks very promising. I called some URLs wth the get_response.py script and the responses look reasonable. I didn't test HA integration (and I don't quite know how to do this: using a different repository and branch with HA).
If you want to try it on HA, you can add my current branch of Vaillant-component to the HACS repositories. It points to the senso_app branch that started this PR. Please note that this branch will not be maintained and is under development.
For the moment, when configuring, you must select the MULTIMATIC or SENSO application.
I have installed this in my HA. See my feedback comment in vaillant-component #190.
+1 from me (as a user) for merging this.
One more thing: The setup assistent is fine, but once setup, it seems these settings cannot be controlled or changed using the UI? I don't know if this is specific to this PR or if it's a general issue of vaillant-component.
I tested it for few hours with 1.13.0 version of the multimatic integration. This works well for multimatic.
@xaviergriffon can I merge it and release ?
Next step is to modify the integration itself
Yes @thomasgermain, I think the pymultiMATIC part contains the essentials for the second part in the integration.
Here is it: https://github.com/thomasgermain/pymultiMATIC/releases/tag/0.7.0b1
version is also available in pypi: https://pypi.org/project/pymultiMATIC/0.7.0b1/
Compatibility with Senso APIs. Most of the code is name or schema mapping. There are some specifics for the Quick Veto part and the time program.
I have provided examples of JSON passed in different situations and unit tests to interpret them. With a fork of your vaillant-component, I'm using this code for some times with heating zones and a hot water circuit. I performed tests of temperature change (Quick Veto), shutdown and resumption of the configured program on the boiler.
I'm not a Python developer, any comments are welcome ;)