thomasgermain / pymultiMATIC

Python interface with Vaillant multiMATIC
MIT License
56 stars 11 forks source link

Fix : Senso setPoint and setBack for Zone and add Manual mode #109

Closed xaviergriffon closed 1 year ago

xaviergriffon commented 1 year ago

Corrected urls and payloads for set_zone_heating_setpoint_temperature and set_zone_heating_setback_temperature methods for Senso. During the tests, I noticed that the Manual mode was not taken into account.

Resolve: #108

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b9df85d) 98.44% compared to head (fef7abb) 98.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ======================================= Coverage 98.44% 98.44% ======================================= Files 28 28 Lines 1931 1931 ======================================= Hits 1901 1901 Misses 30 30 ``` | [Impacted Files](https://codecov.io/gh/thomasgermain/pymultiMATIC/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain) | Coverage Δ | | |---|---|---| | [pymultimatic/model/zone.py](https://codecov.io/gh/thomasgermain/pymultiMATIC/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain#diff-cHltdWx0aW1hdGljL21vZGVsL3pvbmUucHk=) | `98.14% <ø> (ø)` | | | [pymultimatic/api/payloads\_senso.py](https://codecov.io/gh/thomasgermain/pymultiMATIC/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain#diff-cHltdWx0aW1hdGljL2FwaS9wYXlsb2Fkc19zZW5zby5weQ==) | `100.00% <100.00%> (ø)` | | | [pymultimatic/api/urls\_senso.py](https://codecov.io/gh/thomasgermain/pymultiMATIC/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain#diff-cHltdWx0aW1hdGljL2FwaS91cmxzX3NlbnNvLnB5) | `100.00% <100.00%> (ø)` | | | [pymultimatic/systemmanager.py](https://codecov.io/gh/thomasgermain/pymultiMATIC/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain#diff-cHltdWx0aW1hdGljL3N5c3RlbW1hbmFnZXIucHk=) | `94.48% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+Germain)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

thomasgermain commented 1 year ago

@xaviergriffon just need a small rebase since I also modified SystemManager

xaviergriffon commented 1 year ago

@xaviergriffon just need a small rebase since I also modified SystemManager

rebase performed.