[IMP] Improve the code to be SENSO compliant

thomasgermain / pymultiMATIC

Python interface with Vaillant multiMATIC

MIT License

56 stars 11 forks source link

[IMP] Improve the code to be SENSO compliant #56

Closed sylvainvh closed 3 years ago

sylvainvh commented 3 years ago

This PR fix some small bugs with SENSO and clean the code to be more "python"

/!\ This code is not fully functional and it remaining some problems:

I have never tested to set a value (only read)
There is a new operating mode "TIME_CONTROLLED" but I don't know what to do with it
The timeprogram has now a end time and we have to deal with it

thomasgermain commented 3 years ago

This is actually good job, I'm always happy to learn something to be more pythonic :), thanks for that

It would be nice to have some API responses so I can see how the API is working under the hood and also to be able to test the new operating mode and time program

thomasgermain commented 3 years ago

Hey @sylvainvh I know with discuss that I have to cherry pick a commit from master to senso_app, but I can't remember which one is it :sweat_smile:, do you still know ?

thomasgermain commented 3 years ago

I closed both PR, I guess we're gonna wait for MyVaillant to be launched.

Anyway, thanks for your feedback :)