Closed pippinsplugins closed 9 years ago
Posts that display a video get a post format of video
@pippinsplugins From the code it looks like it had multiple input fields where you added a URL for each format, ogv and mp4. It also looks like you had a checkbox for whether or not the video was premium, pp_premium
.
Is that all correct? I've checked your old theme and plugins and the actual creation of the checkbox and input fields are not there, how were these added?
Only MP4 is used now
On Thursday, December 18, 2014, Andrew Munro notifications@github.com wrote:
@pippinsplugins https://github.com/pippinsplugins From the code it looks like it had multiple input fields where you added a URL for each format, ogv and mp4. It also looks like you had a checkbox for whether or not the video was premium, pp_premium.
Is that all correct? I've checked your old theme and plugins but it's not in there.
— Reply to this email directly or view it on GitHub https://github.com/pippinsplugins/theme/issues/38#issuecomment-67591954.
Videos look to be all good now https://staging.pippinsplugins.com/plugin-development-101-general-best-practices/
Just need to make them responsive, thinking of using fitvids.js for this
Oh and I need to make an image that shows when access to video is denied. This look ok? https://gist.github.com/sumobi/090e2cfae41be9e7d723
Videos are responsive now, double check the above snippet and we should be good on this.
Video looks great!
One small thing: looks like this isn't quite working. As a site admin I should be able to see it. Here's a tweaked snippet: https://gist.github.com/pippinsplugins/66d3354d4259cfc5e0a9
Updated. Everything about video looks good to me.
The current site has a video metabox where the URL to a video is entered. The video is then rendered on the page.
This has to be brought back as it's how all member tutorial videos are done.
For example:
Staging: https://staging.pippinsplugins.com/plugin-development-101-what-makes-a-plugin/
Live: https://pippinsplugins.com/plugin-development-101-what-makes-a-plugin/
The video is displayed in the template file like this:
Then in
part-video.php