search

thomasgriffin / theme

Theme for Pippinsplugins.com
2 stars 3 forks source link

Style Simple Notices Pro plugin #6

Closed pippinsplugins closed 9 years ago

pippinsplugins commented 9 years ago

The Simple Notices Pro plugin needs to be properly styled.

These are site wide notices that get used occasionally.

amdrew commented 9 years ago

@pippinsplugins Looks like you have some code already in the custom functionality plugin that enables notices. Should I use that, or delete and use Simple Notices Pro?

amdrew commented 9 years ago

Might keep the version in the custom functionality plugin, looks like a copy of your SNP plugin albiet a few changes for CG Cookie.

amdrew commented 9 years ago

Looks like your custom version only allows the notice to be closed for logged in users. Shows for logged out, but no way to close it.

amdrew commented 9 years ago

screen shot 2014-11-02 at 3 49 04 pm

pippinsplugins commented 9 years ago

Looks good to me! I don't use the notices often so being unable to hide it for logged out users shouldn't be an issue.

On Saturday, November 1, 2014, Andrew Munro notifications@github.com wrote:

[image: screen shot 2014-11-02 at 3 49 04 pm] https://cloud.githubusercontent.com/assets/52581/4874076/e96f1ee2-623a-11e4-8d2e-163bcefe1008.png

— Reply to this email directly or view it on GitHub https://github.com/pippinsplugins/theme/issues/6#issuecomment-61392290.

amdrew commented 9 years ago

Good for now