search

thomashirtz / gym-battleship

Battleship environment for reinforcement learning tasks
MIT License
10 stars 2 forks source link

Installation script fix #4

Closed NiklasZ closed 2 years ago

NiklasZ commented 2 years ago

Hi there,

I'm planning on using this environment for some battleship AIs and noticed a bug in the package installation. It won't actually download the package the battleship environment is in. This means the environments can't be found:

import gym
import gym_battleship
env = gym.make('Battleship-v0')
env.reset()

yields:

Traceback (most recent call last):
  File "/home/niklasz/Desktop/ucla/deep_learning/project/code/src/temp.py", line 2, in <module>
    import gym_battleship
ModuleNotFoundError: No module named 'gym_battleship'

This PR ensures the packages are included when running pip install git+https://github.com/thomashirtz/gym-battleship. For reference here are the logs of the old vs. new installation:

thomashirtz commented 2 years ago

Thank you for the merge request :)