thomasjacquin / allsky-portal

A simple, responsive web interface to control an allsky camera connected to a Raspberry Pi
GNU General Public License v3.0
35 stars 20 forks source link

system.php: allow users to specify fan data #91

Closed EricClaeys closed 2 years ago

EricClaeys commented 2 years ago

There will be a PR in the "allsky" repository to add FAN_DATA_FILE as a new setting in config.sh

This partially addresses Issue #89

EricClaeys commented 2 years ago

@AndreasLMeg Other scripts look up values in config.sh the same way system.php does. The web server doesn't have access to any environment variables from Allsky which is why we need to read config.sh. Most people won't have fan data, and if we had a default we'd still have to check if the file existed and would have to check that it had two numbers in it. I'm working on an update to the allsky/install.sh script that will automatically copy user's settings from their prior installation to the new one. It'll first prompt the user for the location of the old "allsky" folder, and if there is one, will move things like images, ftp-settings.sh, config.sh, and endOfNight_additionalSteps.sh if it exists.