search

thomasjo / atom-latex

Compile LaTeX or knitr documents from within Atom
https://atom.io/packages/latex
MIT License
223 stars 42 forks source link

Fix pdf-view focus #416

Closed yitzchak closed 7 years ago

yitzchak commented 7 years ago

Respect openInBackground setting by saving and re-activating previous pane. Resolves #413

thomasjo commented 7 years ago

Would be awesome to have some tests for this both to ensure we aren't breaking anything and also to guard against future regressions, but I'm not sure it's worth the effort right now. Would likely involve a fair bit of orchestration and pane wizardry :sparkles:

yitzchak commented 7 years ago

I agree. UI tests would be awesome but seem like a lot of work.

I am planning on updating the change log with credit to the issue creator since he did all the work, FYI.

thomasjo commented 7 years ago

I am planning on updating the change log with credit to the issue creator since he did all the work, FYI.

Yeah, was just about to suggest that :smiley: