search

thomasjo / atom-latex

Compile LaTeX or knitr documents from within Atom
https://atom.io/packages/latex
MIT License
223 stars 42 forks source link

Added qpdfview with synctex #442

Closed skidpa closed 7 years ago

skidpa commented 7 years ago

Hi i created a opener for qpdfview with synctex and appendend the package.json file with what i think is the appropriate information. It's really just a modified zathura-opener

this is my first time contributing so i might have made a fool of my self though.

yitzchak commented 7 years ago

Thank you for submitting the PR. We really appreciate any and all code submissions!

So far I just see the issue regarding quoting the file path argument, which I've added a line comment for that.

@thomasjo Can you take a look when you get a chance?

skidpa commented 7 years ago

Your are absolutely right. I shamelessly overlooked that part, it should be "${filePath}"#src:"${texPath}":${lineNumber}:0 or "${filePath}#src:${texPath}":${lineNumber}:0 both seems to work fine on my system with spases in the paths's and without i guess its mostly a matter of which way you preferr. I've fixed it and pushed the first option to my repo anything else i should do?

thomasjo commented 7 years ago

Thanks for adding this! 🥇