search

thomasjo / atom-latex

Compile LaTeX or knitr documents from within Atom
https://atom.io/packages/latex
MIT License
223 stars 42 forks source link

Fix Rscript in AppVeyor #448

Closed yitzchak closed 6 years ago

thomasjo commented 6 years ago

Any idea why this is suddenly breaking? This has worked for a long time. By splitting this across files, we're spreading crucial, inter-dependent steps across multiple files.

Adding the hack to .appveyor.yml is fine if it's truly the only solution, but removing the PATH step entirely from install-knitr is not OK. The idea of the CI scripts is that they should work, with minimal effort, on any build system. I tested these on a Windows VM back in the day by simply setting a few environment variables to "mimic" AppVeyor. If I somehow have to "execute" the YAML file (or run more manual steps), things not that easy.

I don't like changing things the easy way simply to get stuff working. That quickly becomes a house of cards. Then again, if we have no other viable alternative, keep the addition, but remove the deletion.

yitzchak commented 6 years ago

I don't know why this happening. The same set of install steps in DICy seem to work. The only difference was the path setting which is why I changed it. The hack doesn't seem to work so we are back to square one.

yitzchak commented 6 years ago

It looks like this is a bug in R. I got a green board by removing the spaces from all calls to Rscript. I believe that this bug was introduced in r73703 (v3.4.3) and may be resolved by r73849 which has not landed in a release yet.

What would you like to do, get rid of the spaces in Rscript calls or wait for a fix?

yitzchak commented 6 years ago

@thomasjo Can you take a look at this when you get a chance?

yitzchak commented 6 years ago

Bug fixed upstream.