thomasleveil / b3-plugin-customcommands

B3 plugin that allow to define new commands painlessly
2 stars 6 forks source link

<ARG:FIND_PLAYER:NAME> doesn't work correctly upon multiple client matches #1

Closed danielepantaleone closed 10 years ago

danielepantaleone commented 10 years ago

As highlighted in this topic (http://forum.bigbrotherbot.net/general-usage-support/b3-help-please/msg43783/?topicseen#msg43783) there is a problem when b3 retrieves 2 clients instead of a single one.

Since the multiple matches list is shown internally by b3 core, I would return None when the target_client is not found here (https://github.com/thomasleveil/b3-plugin-customcommands/blob/master/extplugins/customcommands.py#L208) and detect None value on the upper level to skip the command execution

thomasleveil commented 10 years ago

thx for the detailled report