search

thomaslindstrom / color-picker

A color picker for the Atom Editor. Right click a color and select color picker to open it.
MIT License
246 stars 50 forks source link

Why not use keymaps.cson? #150

Open AfterDarkness opened 8 years ago

AfterDarkness commented 8 years ago

Just get rid of lines 9-38, in ./ColorPicker.coffee and make a ./keymaps/colorpicker.cson which contains the default key bindings, so that the user can easily configure the key binding to his liking, and restarting won't be required then. Also make a ./menus/something.cson which will have all the menus. This way, if the user doesn't want them, he knows where to comment/delete those lines.

thomaslindstrom commented 8 years ago

Right now, it's too difficult to set up your own key bindings. Hence why I removed the cson file that was previously present, to allow setting a custom trigger key in color-picker settings on the request from a couple of other users.