search

thomaslindstrom / color-picker

A color picker for the Atom Editor. Right click a color and select color picker to open it.
MIT License
246 stars 50 forks source link

error in starting #216

Open mihirsam opened 7 years ago

mihirsam commented 7 years ago

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.12.5 Electron Version: 1.3.9 System: Ubuntu 16.04.2 Thrown From: color-picker package, v2.2.5

Stack Trace

Uncaught TypeError: Cannot read property 'offsetLeft' of null

At /home/mihir/.atom/packages/color-picker/lib/ColorPicker-view.coffee:355

TypeError: Cannot read property 'offsetLeft' of null
    at Object.open (/home/mihir/.atom/packages/color-picker/lib/ColorPicker-view.coffee:355:73)
    at atom-text-editor.<anonymous> (/home/mihir/.atom/packages/color-picker/lib/ColorPicker.coffee:47:23)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:259:29)
    at /usr/share/atom/resources/app.asar/src/command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/usr/share/atom/resources/app.asar/src/window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (/usr/share/atom/resources/app.asar/src/window-event-handler.js:3:59)

Commands

     -7:55 application:new-file (atom-workspace.workspace.scrollbars-visible-always.theme-atom-dark-syntax.theme-one-dark-ui)
     -7:50.8.0 core:save (atom-text-editor.editor.is-focused)
     -7:38.8.0 editor:newline (atom-text-editor.editor.is-focused)
  2x -7:35.2.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
     -7:27.3.0 editor:newline (atom-text-editor.editor.is-focused)
  2x -6:49.1.0 color-picker:open (atom-text-editor.editor.is-focused)
     -6:07.5.0 editor:copy-path (atom-text-editor.editor.is-focused)
  4x -5:46.9.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
     -5:34.9.0 core:move-left (atom-text-editor.editor.is-focused)
     -5:34.5.0 core:move-right (atom-text-editor.editor.is-focused)
  2x -5:33.5.0 core:move-left (atom-text-editor.editor.is-focused)
     -5:33.1.0 core:move-right (atom-text-editor.editor.is-focused)
  8x -5:33 core:move-left (atom-text-editor.editor.is-focused)
     -1:08.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  2x -1:08.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:00.1.0 color-picker:open (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "openEmptyEditorOnStart": false,
    "telemetryConsent": "limited",
    "themes": [
      "one-dark-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
color-picker, v2.2.5 (active)
file-icons, v2.1.2 (active)
minimap, v4.27.0 (active)
atom-dark-syntax, v0.27.0 (active)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (active)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (active)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages
2ovob4ehko commented 7 years ago

It can`t find .scroll-view and .line elements in EditorView. I am noob in coffescript, so I have changed line 355 to this:

if EditorView.querySelector('.scroll-view')? _editorOffsetLeft = EditorView.querySelector('.scroll-view').offsetLeft else _editorOffsetLeft = 20;

and other error to this:

if EditorView.querySelector('.line')? _lineOffsetLeft = EditorView.querySelector('.line').offsetLeft else _lineOffsetLeft = 20;

and color-picker works again