search

thomaslindstrom / no-caffeine-syntax

A dark, crisp and clean Atom Editor syntax theme with no caffeine
MIT License
12 stars 7 forks source link

added string highlighting for golang #17

Closed xh3b4sd closed 7 years ago

xh3b4sd commented 7 years ago

I updated Atom to 1.12.2. I noticed that strings in golang were not highlighted correctly anymore. This is how it looks now.

screen shot 2016-11-12 at 23 24 59

This is how it should look like, which this PR in fact fixes.

screen shot 2016-11-12 at 23 24 09

I feel like the fix of this PR is a hack and no proper solution. I did not dig deeper into how selectors changed in recent Atom upgrades. Therefore my limited understanding of the problem. Does somebody have more information? Should we simply merge this as it is? Here is also a screenshot of the DOM of the shown example above.

screen shot 2016-11-12 at 23 28 52
thomaslindstrom commented 7 years ago

Does it make sense to style .entity.import green instead?

        .entity.import {
             color: @color-green;
        }
xh3b4sd commented 7 years ago

No, the result then is this. Should we just merge this PR for now? Or do you have another idea?

screen shot 2016-11-13 at 13 28 59