search

thomaslindstrom / no-caffeine-syntax

A dark, crisp and clean Atom Editor syntax theme with no caffeine
MIT License
12 stars 7 forks source link

json files customization #23

Closed kostadinnm closed 6 years ago

kostadinnm commented 6 years ago

Hi there. I'm trying out some dark themes and went on using no-caffeine-syntax along with numix-dark-ui. I was wondering whether a little better highlighting could be added for json-files?! Here's how I tweaked the light one I usespectrum-ligth-syntax to alternate the highlighting only for the leaf-nodes of the json structure(the '>' symbol is conflicting css-code and markdown): silly gist And here's a comparison: no_caffeine_atom_theme_suggestion Note that spectrum-ligth-syntax is highlighting non-string json-keys as errors as well.

I think it'll be a good addition, especially for package.json files that are utilized by the node-community. I'm not much into styling, otherwise would've make a better, if not direct suggestion on how that improvement could be done :) Cheers, Kostadin

thomaslindstrom commented 6 years ago

Hey, @kostadinnm! Are you saying you want styling of erroneous JSON syntax? Or maybe different styling of keys and values? Or both?

kostadinnm commented 6 years ago

For now, I think It'd be good if just the values(the leaf-nodes of a json structure) be different color. Something like what I did with the aforementioned theme. That would benefit most, as it's far more clear what values one's using in their package.json files. Maybe you should do it only for the package.json as other json-files may have other needs.

thomaslindstrom commented 6 years ago

Look for this in 0.19.0! Let me know if there is anything else. Here's what it looks like:

screen shot 2018-06-10 at 02 50 56

kostadinnm commented 6 years ago

Charming! I have no other suggestions - I just customized my comments NOT to be italic and use a warmer chrome-theme, but I see you prefer a seti-like one. Skol, Kostadin

thomaslindstrom commented 6 years ago

Yeah, I use seti-ui. It works well with no-caffeine-syntax!