Open slovdahl opened 1 year ago
This is also happening in the iOS companion app but is fine in Safari.
@finalbillybong Interesting, I did try it in my wife's iOS companion app too without being able to reproduce. Do you have an example of it?
I sure do.
And I Safari itβs fine.
Same issue on a simple chrome window on Android here ..
I would like to jump on the reporting bandwagon. Fullscreen pop up works fone but does not work in my use case. Wide, normal, and none have the same overflow effect which cuts off vital info.
I do not that i have my text size accessibility settings (android, pixel 6 pro) set to the smallest font size, if i put back to normal the pop up seems fine. Unfortunately i cant have the normal font size.
Noticing this on my Pixel 7 Pro as well, and only on the companion app.
Not an issue in a web browser on my Pixel 7 Pro or in Home Assistant Desktop (Windows 11). Oddly enough, also not an issue on a Pixel 1, but it seems to be running an older version of the app.
Much guesswork here now.. Looks like the OnePlus 8 Pro viewport is wider than 450 px but narrower than 560 px, and for some reason the --popup-min-width
from these defaults is not applied. Instead --mdc-dialog-min-width
falls back to a default of 560 px => overflow.
Anyway, by adding π to my popups I managed to work around it.
style: |
--popup-min-width: 400px;
And in the full example in the original post:
title: Overflow bug
views:
- theme: Backend-selected
title: Home
type: panel
badges: []
cards:
- type: button
entity: light.light_group
name: Lights
tap_action:
action: fire-dom-event
browser_mod:
service: browser_mod.popup
data:
title: Lights
style: |
--popup-min-width: 400px;
content:
type: entities
entities:
- entity: light.light_1
name: Light 1
- entity: light.light_2
name: Light 2
You saint. Thank you!
Opening π in Chrome and Firefox on my OnePlus 8 Pro yields some interesting results π€
<!DOCTYPE html>
<html>
<body><h1><script type="application/javascript">document.write(window.innerWidth);</script></h1></body>
</html>
Firefox:
Chrome:
Same issue for me in companion app on Pixel 6 Pro.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Still an issue.
Same probleme here, iOS 16 (wife) and iOS 17 (me), companion app, safari and chrome have the issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Still an issue.
This is still and issue
Still an issue.
My Home Assistant version: 2023.1.5 HA Android companion version: 2023.1.1-full
I'm not sure where exactly the bug is, but I need to start somewhere. Please point me in the right direction if I'm in the wrong place.
What I am doing:
Opening a
browser_mod
popup (intap_action
for abutton
card) usingaction: fire-dom-event
andservice: browser_mod.popup
.What I expected to happen:
The popup is opened and does NOT overflow.
What happened instead:
I have been running the same HA server, HA companion app and all HACS plugin versions for about a week when this suddenly started happening ~1 week ago. I'm fairly confident that a Chrome or Android System WebView update broke it as both the HA companion app and Chrome are broken in the same way.
I managed to attach my desktop Chrome's dev tools to my Android phone's Chrome and was able to tweak the width of the popup and get it fully visible, but I'm way out of my comfort zone when it comes to CSS (and JS) these days so I wasn't able to understand why it happened. But I'm happy test specific things out via the Chrome dev tools if needed.
Minimal steps to reproduce:
Minimal dashboard that reproduces the problem by tapping on the card (just replace the three light entities with lights or switches):
HA companion app on Android
Firefox on Android
Error messages from the browser console:
Nothing interesting in the console on any of the desktop browsers, but the Firefox one attached:
By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:
[x] Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
[x] Have made sure I am using the latest version of the plugin.
[x] Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.
[x] Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.