thomasloven / hass-browser_mod

🔹 A Home Assistant integration to turn your browser into a controllable entity and media player
MIT License
1.31k stars 186 forks source link

HA 2023.4 Hide header not working #566

Closed limitless00net closed 1 year ago

limitless00net commented 1 year ago

My Home Assistant version: 2023.4

What I am doing: I updated to HA 2023.4

What I expected to happen: Header should be hidden.

What happened instead: Header are not hidden.

Minimal steps to reproduce: I just updated.

Error messages from the browser console: Nothing

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

mdb17 commented 1 year ago

I am seeing this as well

jcbshw commented 1 year ago

Also seeing the same with hiding the sidebar

mkcologne commented 1 year ago

Put me on the list. For Sidebar as well.

w1tw0lf commented 1 year ago

Sidebar and header not hiding this side

radoprajitno commented 1 year ago

I found the same issue. It also affect the HACS kioskmode hide header functions.

rakvikx commented 1 year ago

same here! sidebar and header

guirem commented 1 year ago

Same here for sidebar (i'm not using header) since 2023.4 update

pergolafabio commented 1 year ago

ah, ok, yeah, i was using kiosk mode, but it was broken, wanted to try out this one instead, but it doesnt work indeed, now i know its not me The beta kiosk mode is working tough, the one from the gist , for people want to use it: https://gist.github.com/elchininet/9a2648ea0016d3194072712c745c5ad2

TheBassfly commented 1 year ago

Samen for me.

Tha whole Lovelace seemed top be changed, as all my themes don't have any background anymore.

laczynskik commented 1 year ago

with 'wallpanel lovelace' work well, hiding by CSS..

MackoMici commented 1 year ago

same here! sidebar and header

filippo196302 commented 1 year ago

same here! sidebar and header

pklijzing commented 1 year ago

Instead of all saying "Same", just thumbs up the first post to keep this thread clean. Pretty please 😁

olibos commented 1 year ago

Hello, if this issue is blocking, you can try my workaround: https://github.com/olibos/hass-browser_mod/blob/feature/2023.4-workaround/custom_components/browser_mod/browser_mod.js

Just replace the one in your config folder: /config/custom_components/browser_mod/browser_mod.js

and delete the gzip version: /config/custom_components/browser_mod/browser_mod.js.gz

Then restart your HomeAssistant: Developer Tools > Check and Restart > Restart And select "Restart Home Assistant": image

Attention: this workaround works only in 2023.4+

Let me know if it works for you!

image

TheBassfly commented 1 year ago

Hello, if this issue is blocking, you can try my workaround: https://github.com/olibos/hass-browser_mod/blob/feature/2023.4-workaround/custom_components/browser_mod/browser_mod.js

Just replace the one in your config folder: /config/custom_components/browser_mod/browser_mod.js

and delete the gzip version: /config/custom_components/browser_mod/browser_mod.js.gz

Then restart your HomeAssistant: Developer Tools > Check and Restart > Restart And select "Restart Home Assistant": image

Attention: this workaround works only in 2023.4+

Let me know if it works for you!

image

Nope

Doesn't work here.

wattsy74 commented 1 year ago

Hello, if this issue is blocking, you can try my workaround: https://github.com/olibos/hass-browser_mod/blob/feature/2023.4-workaround/custom_components/browser_mod/browser_mod.js

Just replace the one in your config folder: /config/custom_components/browser_mod/browser_mod.js

and delete the gzip version: /config/custom_components/browser_mod/browser_mod.js.gz

Then restart your HomeAssistant: Developer Tools > Check and Restart > Restart And select "Restart Home Assistant": image

Attention: this workaround works only in 2023.4+

Let me know if it works for you!

image

Didn't work for me either

olibos commented 1 year ago

Maybe a cache issue? When you download the file on your http[s]://[ha]/browser_mod.js Is it the same as the one on my link? It should contains the following text: e.style.setProperty("--header-height","0px")

wattsy74 commented 1 year ago

Maybe a cache issue? When you download the file on your http[s]://[ha]/browser_mod.js Is it the same as the one on my link? It should contains the following text: e.style.setProperty("--header-height","0px")

Yes of course it was caching, I feel so stupid now!!.. Thanks for the reply

olibos commented 1 year ago

No worries, I hope we will soon have an official release with the fix 😉

Tanjohnson99 commented 1 year ago

Same issue here. Sidebar is not hide.

aldor443 commented 1 year ago

Hello, if this issue is blocking, you can try my workaround: https://github.com/olibos/hass-browser_mod/blob/feature/2023.4-workaround/custom_components/browser_mod/browser_mod.js

Just replace the one in your config folder: /config/custom_components/browser_mod/browser_mod.js

and delete the gzip version: /config/custom_components/browser_mod/browser_mod.js.gz

Then restart your HomeAssistant: Developer Tools > Check and Restart > Restart And select "Restart Home Assistant": image

Attention: this workaround works only in 2023.4+

Let me know if it works for you!

image

This solution only works in browser, not in apk ???

grssll commented 1 year ago

Not working!

jcbshw commented 1 year ago

Hello, if this issue is blocking, you can try my workaround: https://github.com/olibos/hass-browser_mod/blob/feature/2023.4-workaround/custom_components/browser_mod/browser_mod.js

Just replace the one in your config folder: /config/custom_components/browser_mod/browser_mod.js

and delete the gzip version: /config/custom_components/browser_mod/browser_mod.js.gz

Then restart your HomeAssistant: Developer Tools > Check and Restart > Restart And select "Restart Home Assistant": image

Attention: this workaround works only in 2023.4+

Let me know if it works for you!

image

Thanks I can confirm this works for me on iOS and Desktop after clearing cache.

terriblefox commented 1 year ago

seems kiosk mode integration fixed it.

vhardono commented 1 year ago

@olibos I followed your workaround and refreshed my browser. The header background is now gone, however a small portion (bottom half) of the header title is visible/protruding from the top of screen. Is there any other configuration I need to adjust for removing the header title completely?

Untitled

olibos commented 1 year ago

Hello @vhardono , Thank you for your feedback.

I think it's a limitation of my workaround. My personal use case hide both the sidebar and header. If no official solution come on tuesday, I will have some time to check that use case and update my PR + link of the workaround.

vhardono commented 1 year ago

thanks for your effort anyway! :) I just deleted the header title - "Dashboard" so it's not visible anymore, but for sidebar it's not possible. So i will temporarily hide the sidebar first until official fix is released

dselzle commented 1 year ago

This still seems to be broken for me after your fix. HA 2023.4.1

drjjr2 commented 1 year ago

This still seems to be broken for me after your fix. HA 2023.4.1

Not sure if this applies to you but I thought it wasn't working with FullyKiosk but then I cleared the cache (in FullyKiosk) and all was well.

Zeunas commented 1 year ago

Def clear cache, that should work.

dselzle commented 1 year ago

This still seems to be broken for me after your fix. HA 2023.4.1

Not sure if this applies to you but I thought it wasn't working with FullyKiosk but then I cleared the cache (in FullyKiosk) and all was well.

Clearing the Fully Kiosk cache worked thanks! Thought restarting the app would be enough, but I guess not.

juan11perez commented 1 year ago

The fix is not working correctly. The title bar is indeed hidden, but I can not access the side panel. I've cleared cache and restarted the app various times.

thomasloven commented 1 year ago

Do you mean the button to reveal the sidebar - which is in the header - is not vissible when you've chosen to hide the header?

limitless00net commented 1 year ago

The fix is not working correctly. The title bar is indeed hidden, but I can not access the side panel. I've cleared cache and restarted the app various times.

Same here.

juan11perez commented 1 year ago

@thomasloven Thank you. In my case that side panel button has always been hidden if I choose the hide title option.

However, I was always able to see the side panel by swiping right on the screen. The side panel will momentarily appear and then hide again.

Right now that's not possible. I.e. the side panel is fully locked and can't be accessed. The only way is to disable the 'hide title' option

pergolafabio commented 1 year ago

This is not related to Browser mod, they changed something in frontend:

https://github.com/home-assistant/android/issues/3460