thomasloven / hass-browser_mod

🔹 A Home Assistant integration to turn your browser into a controllable entity and media player
MIT License
1.29k stars 182 forks source link

Cannot Close Popup in mobile browser #708

Open 400HPMustang opened 3 months ago

400HPMustang commented 3 months ago

My Home Assistant version: 2024.5.3

What I am doing:

Trigger a popup using browser_mod.popup on Safari on iOS

What I expected to happen:

To be able to click an area outside the popup so that it will close

What happened instead: The popup opens full screen and there is no space outside the popup to click so that it will close

Minimal steps to reproduce: Create custom button card with the popup below that has enough entites so that you have to scroll on a mobile browser Trigger popup on mobile browser Popup opens full screen and cannot be closed

# The least amount of code or steps possible to reproduce my error
service: browser_mod.popup
target: {}
data:
  dismissable: true
  content:
    type: custom:auto-entities
    show_empty: false
    card:
      type: entities
      title: Lights on
      show_header_toggle: false
    filter:
      include:
        - domain: light
        - domain: switch
      exclude:
        - state: "off"
        - state: unavailable
        - hidden_by: user
        - integration: adaptive_lighting
        - integration: bhyve
        - integration: unifi
        - integration: sonos
        - name: Fountain
        - name: /[Pp]ower/
        - name: /[Pp]ump/
        - name: /[Ww]ax/
        - name: /[Mm]ode/
        - name: /[Bb]ridge/

# Put your code/steps here

Error messages from the browser console:

// Select everything from the browser console and copy it

// Paste it here

IMG_2409

By replacing the space in the checkboxes ([ ]) with an X below, I indicate that I:

Spegeli commented 1 month ago

Look at that fix request:

https://github.com/thomasloven/hass-browser_mod/pull/619

Instead of Tap on empty space, the back-swipe should Close the Pop-up too.