search

thomasloven / hass-browser_mod

🔹 A Home Assistant integration to turn your browser into a controllable entity and media player
MIT License
1.34k stars 186 forks source link

Fix more-info popup not working #732

Closed sebastian-bartkowiak closed 3 months ago

sebastian-bartkowiak commented 3 months ago

Fixes #719

thomasloven commented 3 months ago

This seems to do it. Thanks!

Starcon79 commented 3 months ago

Hello, unfortunately, it still doesn't work for me despite the update.

pfiorentino commented 3 months ago

Hello, unfortunately, it still doesn't work for me despite the update.

Agreed, it works on the HA Android App, but the web version is still not working (Chrome 127 on MacOS Sonoma)

thomasloven commented 3 months ago

If you go to the Browser Mod settings page. What does it say in the upper right corner?

pfiorentino commented 3 months ago

If you go to the Browser Mod settings page. What does it say in the upper right corner?

2.3.1

I performed the update a few hours ago :)

Screenshot 2024-08-01 at 22 36 04
Starcon79 commented 3 months ago

If you go to the Browser Mod settings page. What does it say in the upper right corner?

Screenshot_2024-08-01-22-36-59-621_io.homeassistant.companion.android-edit.jpg

pfiorentino commented 3 months ago

That being said, it's not worse, it doesn't beak anything.

I don't think we need to revert this PR, it's just not fixing the issue completely.

thomasloven commented 3 months ago

Sorry. I realized that number is actually pulled from the wrong source, so it's not necessarily representative of which version is loaded in your browsers cache.

Make sure to do a hard refresh of the cache.

Starcon79 commented 3 months ago

Sorry. I realized that number is actually pulled from the wrong source, so it's not necessarily representative of which version is loaded in your browsers cache.

Make sure to do a hard refresh of the cache.

"Great, it worked. I cleared the cache again, and now the pop-up is working. Thanks."

pfiorentino commented 3 months ago

Sorry. I realized that number is actually pulled from the wrong source, so it's not necessarily representative of which version is loaded in your browsers cache.

Make sure to do a hard refresh of the cache.

Also worked here! 🎉

I'm 100% sure to have cleared the cache multiple times before writing my first comment yesterday though, very strange 🤔

Anyway! Thanks for your support! ❤️

thomasloven commented 3 months ago

I'm 100% sure to have cleared the cache multiple times before writing my first comment yesterday though, very strange 🤔

That's caching. It may only work on the tenth try, and then again not on the eleventh...