search

thomasloven / hass-favicon

🔹 Change the favicon of your Home Assistant instance
MIT License
104 stars 19 forks source link

no Brand icon... in the integrations list #16

Open Mariusthvdb opened 3 years ago

Mariusthvdb commented 3 years ago

Hardly a first world problem, but in the list of integrations, Fav-icon is failing a brand-icon.

Schermafbeelding 2020-10-29 om 23 17 51

leading to this error in inspector: 

Failed to load resource: the server responded with a status of 404 ()
Schermafbeelding 2020-10-29 om 23 14 48

would be cool if this nice little utility would show a (fav)icon.

dawiinci commented 2 years ago

Just wanted to add this issue too. Seems like an easy fix. 👍

Kind of ironic, though, we now have a custom icon, but the plugin itself does not.

You could just use the icon that we defined, right?

Mariusthvdb commented 2 years ago

You could just use the icon that we defined, right?

what exactly are you saying here? Are you going to add it in a PR?

dawiinci commented 2 years ago

It was just a suggestion.

mingaldrichgan commented 1 year ago

I briefly looked into this (just to satisfy my own curiosity) and it looks like a dynamic icon will not be possible. https://github.com/home-assistant/brands is the repo that holds these icons, if anyone wants to design or propose something that makes sense for this integration.

hiagocosta commented 1 year ago

a good integration that helps on visual !!

could have a fix for this issue?

image

renarena commented 1 month ago

Idea: the blue favicon and one in another color in front of them, like the copy icon. What about "updating" the favicons in folder test too?