search

thomasloven / hass-fontawesome

🔹 Use icons from fontawesome in home-assistant
Other
274 stars 52 forks source link

Appears that custom icons with a hyphen (-) in their name do not load #47

Closed Teku16 closed 10 months ago

Teku16 commented 2 years ago

I tried to upload a pro icon to the /custom_icons folder, and struggled for a bit before renaming it

Before: tree-christmas.svg (nothing loaded) After: christmastree.svg (loads fine)

I am unsure if I botched something or not, but I just installed master and restarted HA

jdubbs4051 commented 2 years ago

can confirm this as well. Fresh HA installation and new user of this plugin

GitHubGoody commented 2 years ago

Same here, but also occurs when using hyphenated free fonts from the Font Awesome library

For example, boxes-packing does not work.

Milithor commented 1 year ago

Issue still present, confirming here as well. Seems development has stopped.

TheFes commented 1 year ago

Filter on free icons in the gallery, they will work, even with a hyphen

EvertJob commented 1 year ago

Filter on free icons in the gallery, they will work, even with a hyphen

Sure? Because here that don't work either.

For example: fas:building returns the icon of a building but fas:building-shield does not return the building with shield.

There is a list of icons that work: https://github.com/thomasloven/hass-fontawesome/tree/master/custom_components/fontawesome/data/regular

TheFes commented 1 year ago

Well, I didn't check all of them, but for the ones I tested with the free icons with hyphen worked. So it is not caused by the hyphen.

EvertJob commented 1 year ago

Well, I didn't check all of them, but for the ones I tested with the free icons with hyphen worked. So it is not caused by the hyphen.

That's right!

The full folder is here: https://github.com/thomasloven/hass-fontawesome/tree/master/custom_components/fontawesome/data/solid

I've people would like to add there own icons: Place them in the config/custom_components/fontawesome/data/solid folder. Just give them a logical name and it's possible to use them!

thomasloven commented 10 months ago

Cannot reproduce bild

boxes-packing and building-shield were added in Fontawesome 6.0 and therefore were not included in this pack before today.