search

thomasloven / lovelace-card-mod

🔹 Add CSS styles to (almost) any lovelace card
MIT License
1.08k stars 168 forks source link

Remove april fools joke #191

Closed Hypfer closed 2 years ago

Hypfer commented 2 years ago

Given that there are already #189 and #190 even though it's not yet the 1st of april in europe and the US, there could be a shitstorm coming. I'm certain that there were only good intentions with this joke so I hope that the discussion will stay civilized.

Anyway, sneaking in a timebomb that breaks the library for a whole day is bad. It's certainly not as bad as starting to delete files based on the users geoIP as we've seen recently with popular npm packages, but it's still very much not good.

Please don't do that as it erodes trust. Without trust in the maintainers, people might stop updating their software to avoid these kinds of surprises, as reviewing all commits of all software used every time simply isn't feasible for most. In fact, with a project as end-user-focussed as home assistant, a lot of users of this card likely won't be able to do said code review at all.

What makes matters worse is that you're the author of a lot of high quality and widely used lovelace cards, which is why there are a lot of people trusting you based on that work and the standing in the community.

Do we now have to review all those cards? Do we have to question other core community members now?

I know it's just a rotation by a random angle but I hope you see my point here. The fact that it does something unexpected which was hidden in some other commit is just frightening even if the thing that is done isn't that harmful.

frenck commented 2 years ago

Honestly: This isn't cool.

thomasloven commented 2 years ago

I see your point, and agree.

I may have F-ed up.

The fix has been released, but I'll leave this PR open so it can be seen.

jayakornk commented 2 years ago

I see your point, and agree.

I may have F-ed up.

The fix has been released, but I'll leave this PR open so it can be seen.

Thanks for this awesome plugin!

davoau commented 2 years ago

I have just discovered this, my home assistant was freezing, unstable, and after rebooted several times before posting on home assistant forum to be told about this I was getting really pissed off as only just up graded to latest version and had no end of problems and then this this morning.. And I am in +10:00 time zone, so only NZ before... good luck with today thomas

thomasloven commented 2 years ago

good luck with today thomas

Thanks. I'll need that... Off to bed soon, won't be sleeping much...

jonathantidwell commented 2 years ago

Although I can see someone getting rankled by this, at least you have two people who thought it was humorous. The girlfriend and I had a brief "what the heck" moment, followed by a chuckle.

ernst77 commented 2 years ago

Well me and my gf thought it was funny. No issues for us as we have big screen so tilt does not hide or break anything. I can see this being an issue for smaller screens.

davidrustingha commented 2 years ago

@thomasloven I had no issues either, and I thought it was kinda funny too.

Sholofly commented 2 years ago

@thomasloven Hope you had a good sleep. Head up! However it was meant to be innocent, people explained why it wasn't. You've showed that you understand why and that you've learned a lesson out of this. You've apologized for it and took concrete actions to undo it. Actually, there isn't more you can do. There's no one here that can say that they haven't made misjudgements. Not in their jobs, neither in their private life. Please continue your good work as before and everybody that lost confidence will regain it. Because thats what you do the best!

asherw commented 2 years ago

Honestly: This isn't cool.

Honestly: This was fantastic. Thanks for all your hard work.

CoreyReding commented 2 years ago

I for one have no clue what I am doing to begin with, so this caught me off guard. That being said, I LOVE it..... there is nothing better in this crazy world than to find others have a since of humor as I do. Keep up the great work......

Metus88 commented 2 years ago

Thanks a lot for your efforts! You did (and you will) a great job! Everyone, everyday, learns from a little mistakes. I appreciate your apology and your fix..... and most important you had teach us to be more focused in what we install and from who. You are a good person so no big problems.... but maybe another programmer could not be like you. Good luck and thanks again

nagyrobi commented 2 years ago

Bad joke. Thanks for removing it.

DafP commented 2 years ago

Quite sad seeing the number of people crying on here about a slight change of angles on cards is laughable. It's happened for less than a day, I hope everyone who has complained is still alive and well. Fingers crossed it hasn't killed anyone. Thanks for all your hard work @thomasloven

dnestico commented 2 years ago

Lol this was funny when I saw it, didn't break my dashboard luckily so I ain't mad

bendauphinee commented 2 years ago

I also found it funny (I thought I was having a stroke for a second until I checked on my PC), though I get how some people may have found the rotations a little extreme. Take heart, it was funny, though a lesson to all pranksters, make a opt-out or disable button ;)

At the end of the day, people are taking it way too seriously. It's your software, not theirs, so do what you want, as long as it ain't malicious. I still trust your work, and this actually humanizes you a bit more for me, which I completely support!